Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the range of the decl's name #235

Closed
wants to merge 1 commit into from

Conversation

kjeremy
Copy link
Contributor

@kjeremy kjeremy commented Nov 20, 2018

Fixes #230

@matklad
Copy link
Member

matklad commented Nov 20, 2018

Could we add a high-level rename test here as well?

@kjeremy
Copy link
Contributor Author

kjeremy commented Nov 20, 2018

Hm. Do we have tests for LSP handlers?

@matklad
Copy link
Member

matklad commented Nov 20, 2018

No, but I think we should test it on the analysis layer, not on the LSP layer. That is, we can move the bulk of handle_rename into ra_analysis, and then write a test for it there.

@DJMcNab
Copy link
Contributor

DJMcNab commented Dec 30, 2018

@kjeremy do you want someone to make this change, or are you willing to update it yourself?

@kjeremy
Copy link
Contributor Author

kjeremy commented Dec 30, 2018 via email

bors bot added a commit that referenced this pull request Dec 30, 2018
375: Move renames into ra_analysis and rename the correct range r=DJMcNab a=DJMcNab

Fixes #230. Supersedes #235.

TODO: add some tests for this

Co-authored-by: DJMcNab <[email protected]>
@DJMcNab
Copy link
Contributor

DJMcNab commented Dec 30, 2018

#375 supersedes this - I think we can close.

@matklad matklad closed this Dec 30, 2018
@kjeremy kjeremy deleted the fix-mut-rename branch February 12, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants