Skip to content

Follow symlinks when scanning the sysroot for proc-macro dylibs #23297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChayimFriedman2 merged 1 commit into from
Sep 5, 2026
+4 −1
Merged

Follow symlinks when scanning the sysroot for proc-macro dylibs #23297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/project-model/src/build_dependencies.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,10 @@ impl WorkspaceBuildScripts {
let proc_macro_dylibs: Vec<(String, AbsPathBuf)> = std::fs::read_dir(target_libdir)?
.filter_map(|entry| {
let dir_entry = entry.ok()?;
if dir_entry.file_type().ok()?.is_file() {
// Use `fs::metadata` rather than `DirEntry::file_type` so that symlinks
// are followed; sysroots assembled out of symlinks (e.g. by nix) link
// the proc-macro dylibs into the target libdir.
if std::fs::metadata(dir_entry.path()).ok()?.is_file() {
let path = dir_entry.path();
let extension = path.extension()?;
if extension == std::env::consts::DLL_EXTENSION {
Expand Down