fix: Fix NamedTempFile - #23257
Merged
Merged
Conversation
- Use `OpenOptions::write(true)`, otherwise it always fails. - If unable to copy the proc macro DLL in the proc macro server, use the original instead to at least succeed. - For Cargo.lock, use a temporary directory instead as Cargo only accepts literally-named Cargo.lock files, and also because `/proc/self/fd` does not work for other processes. Fortunately unlike the proc macro server we do run `Drop` for those.
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
enabled auto-merge
August 30, 2026 00:35
rustbot
removed
the
S-waiting-on-review
Member
|
@ChayimFriedman2 would tomorrow be fine, so it matches the normal release syncs? |
Contributor
Author
|
Oh the previous PR wasn't synced yet (if it would, Windows nightly users wouldn't have proc macro support at all). Then yes this is fine. |
Member
|
@ChayimFriedman2 do you want to add a dependency on |
Contributor
Author
|
Wait. Don't we check proc-macro-srv in CI? That's not good. Anyway it doesn't really matter to me if we remove this logging or add tracing as a dependency. |
Member
|
I don't remember exactly, but if we do, we probably check on Linux only. |
Contributor
Author
|
That shouldn't matter for this because stdx is still included for Linux. But we also should check on other platforms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenOptions::write(true), otherwise it always fails./proc/self/fddoes not work for other processes. Fortunately unlike the proc macro server we do runDropfor those.Thanks to @onlycs for discovering those.
I'm merging this myself because this can make the proc macro server not working at all on Windows. @lnicola may I also invite a sync?