Skip to content

Conversation

@cry-inc
Copy link
Contributor

@cry-inc cry-inc commented Jan 9, 2026

See bug report #21435 for details on what case exactly is fixed.

Before this fix the ignore attribute would be only handled correctly when used like this:

#[test]
#[ignore]
fn example_a() {}

Now it can also handle cases where a an optional reason is specified:

#[test]
#[ignore = "some reason"]
fn example_b() {}

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2026
@rustbot

This comment has been minimized.

@cry-inc cry-inc changed the title Fix issue #21435 and add ignore flag also for attributes with value Fix issue #21435: Add ignore flag also for attributes with value Jan 9, 2026
@cry-inc cry-inc changed the title Fix issue #21435: Add ignore flag also for attributes with value Bugfix: Add ignore flag also for attributes with value Jan 9, 2026
@cry-inc cry-inc force-pushed the bugfix/fix-ignore-attribute-with-reason branch from 4be7bc1 to ca76c20 Compare January 9, 2026 17:38
@cry-inc cry-inc changed the title Bugfix: Add ignore flag also for attributes with value Fix ignore flag for test attributes with values Jan 10, 2026
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Jan 10, 2026
Merged via the queue into rust-lang:master with commit e42e8ff Jan 10, 2026
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants