-
Notifications
You must be signed in to change notification settings - Fork 1.9k
default_field_values #21408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
default_field_values #21408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChayimFriedman2
requested changes
Jan 5, 2026
c06113d to
046077b
Compare
kouhe3
commented
Jan 8, 2026
ChayimFriedman2
requested changes
Jan 9, 2026
18 tasks
ChayimFriedman2
approved these changes
Jan 26, 2026
Contributor
ChayimFriedman2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just rebase, and also please squash with a useful commit message.
- Added `RecordSpread` enum to distinguish between no spread, field defaults, and spread expressions - Updated `FieldData` to include `default_value` field - Modified record literal lowering to handle default field values - Updated diagnostics to check for missing fields considering defaults - Added methods to get matched fields for records for completions - Enhanced hover support for struct rest patterns
77f1415 to
8c5a9eb
Compare
ChayimFriedman2
approved these changes
Jan 26, 2026
Contributor
ChayimFriedman2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #19780
Add enum and field to track
=and..Create a new function to determine match and missing msg
behavior