fix: Fix a case where completion was unable to expand a macro #18723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Dec 20, 2024
ChayimFriedman2
force-pushed
the
tracing-complete
branch
4 times, most recently
from
13d4fed to
585ecfc
Compare
|
Does salsa 3 already have db forking or it's only planned? |
I think some very rudimentary forking is implemented, but the stuff that we need specifically (the fork having copy on write semantics aka speculative execution) is still missing |
Veykril
approved these changes
Dec 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Which caused the macros of the popular `tracing` crate to not offer completions. The reason is rather complicated: it boils down to macro ignoring their input and completion always choosing the first expansion.
ChayimFriedman2
force-pushed
the
tracing-complete
branch
from
585ecfc to
02d47f3
Compare
|
Needed to rebase and bless - @Veykril can you re-approve? Thanks. |
Veykril
approved these changes
Dec 20, 2024
This was referenced Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which caused the macros of the popular
tracingcrate to not offer completions.The reason is rather complicated: it boils down to macro ignoring their input and completion always choosing the first expansion.
What started as a fairly simple feature request turned out to be a nightmary-ish group of changes on top of something that resembles a pile of hacks more than anything else (completions in IDEs). It turns out, well, this is not so simple. But at least it is fixed now, and tracing finally offers delicious completions!
Recording.2024-12-20.023324.mp4
Fixes #18719.