-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename object_safety #18205
Rename object_safety #18205
Conversation
Closes #18185 |
Do you mean https://doc.rust-lang.org/nightly/nightly-rustc/rustdoc_json_types/struct.Trait.html#structfield.is_object_safe ? It has nothing to do with rust-analyzer because it's for building rustdoc. BTW I think that this should be merged after rust-lang/lang-team#286 because "dyn compatiblity" is not an official term until it's done |
Its FCP is completed so it is effectively done. |
Up to a trait implemented by another package, linking to $CARGO_HOME/registry/cache/index.crates.io-6f17d22bba15001f/
e545395
to
4255cae
Compare
Thanks! |
☀️ Test successful - checks-actions |
First PR here (yay!), so I read some of the getting started docs. There are a couple references to
handlers.rs
, which as far as I can tell has been refactored intohandlers/*.rs
. I made some tweaks to that in one commit. There is one fixme about a function calledto_lsp_runnable
, which I can't find anywhere at all. I can update that if I get some more info there.Otherwise I changed references to object safety, is object safe, etc., trying to match case/style as I went. There was one case I found where there's a trait from somewhere else called
is_object_safe
, which I found defined in my cargo registry. I didn't touch that for now, just marked it with a fixme