internal: remove Default from OpQueue
#18195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Wilfred
reviewed
Sep 26, 2024
Wilfred
reviewed
Sep 26, 2024
Contributor
Author
|
The test failures are legitimate, fwiw. |
Veykril
reviewed
Sep 27, 2024
davidbarsky
force-pushed
the
davidbarsky/push-xkqnsyksmzqv
branch
from
29c9834 to
0c58839
Compare
Contributor
Author
|
If there are no objections, I'll merge this after Monday's release. This change feels like it has a large blast radius. |
Veykril
reviewed
Sep 30, 2024
davidbarsky
force-pushed
the
davidbarsky/push-xkqnsyksmzqv
branch
2 times, most recently
from
0ff9e51 to
b66d3ff
Compare
davidbarsky
force-pushed
the
davidbarsky/push-xkqnsyksmzqv
branch
from
b66d3ff to
fc6eb66
Compare
Veykril
approved these changes
Sep 30, 2024
Member
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Oct 14, 2024
…eykril internal: switch remaining OpQueues to use named structs Building atop of #18195, I switched `GlobalState::fetch_build_data_queue` to use a struct instead of a tuple. (I didn't switch `fetch_proc_macros_queue` to not return a bool, as the return value is only used in one spot.)
bors
added a commit
that referenced
this pull request
Oct 14, 2024
…avidbarsky internal: switch remaining OpQueues to use named structs Building atop of #18195, I switched `GlobalState::fetch_build_data_queue` to use a struct instead of a tuple. (I didn't switch `fetch_proc_macros_queue` to not return a bool, as the return value is only used in one spot.)
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Oct 17, 2024
…rpoq, r=davidbarsky internal: switch remaining OpQueues to use named structs Building atop of rust-lang/rust-analyzer#18195, I switched `GlobalState::fetch_build_data_queue` to use a struct instead of a tuple. (I didn't switch `fetch_proc_macros_queue` to not return a bool, as the return value is only used in one spot.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Wilfred and I were talking about
OpQueueand we identified one symptom of its (relative) weirdness is thatlast_op_resultreturns aT::default(); notOption<&T>, which means it's not possible to distinguish between "theOpQueuehasn't run yet" and "the OpQueue ran, but didn't produce a result". This branch fixes that.