Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Require rust 1.81 #18188

Merged
merged 1 commit into from
Sep 26, 2024
Merged

internal: Require rust 1.81 #18188

merged 1 commit into from
Sep 26, 2024

Conversation

darichey
Copy link
Contributor

rust-analyzer doesn't build on 1.80 because we use #[expect(lint)]:

error[E0658]: the `#[expect]` attribute is an experimental feature
  --> crates/hir-expand/src/prettify_macro_expansion_.rs:11:1
   |
11 | #[expect(deprecated)]
   | ^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #54503 <https://github.com/rust-lang/rust/issues/54503> for more information

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2024
@lnicola
Copy link
Member

lnicola commented Sep 26, 2024

@ChayimFriedman2 think we can switch that to allow? 1.81 is still relatively recent, and we've had complaints before. Also, is the trailing _ intended?

@ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 think we can switch that to allow? 1.81 is still relatively recent, and we've had complaints before

I thought our policy is to support latest stable version, but if this is a problem, yes we can switch that to #[allow].

Also, is the trailing _ intended?

Yes, it's because we import the function with the same name from the module (and only export it), so they need to have different names.

@lnicola
Copy link
Member

lnicola commented Sep 26, 2024

I thought our policy is to support latest stable version

On paper yes, but we're been less strict in the past. But I guess it's been three days and nobody complained yet so..

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 26, 2024

📌 Commit 0536f18 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Sep 26, 2024

⌛ Testing commit 0536f18 with merge af9a658...

@bors
Copy link
Collaborator

bors commented Sep 26, 2024

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing af9a658 to master...

@bors bors merged commit af9a658 into rust-lang:master Sep 26, 2024
11 checks passed
@lnicola lnicola changed the title Require rust 1.81 internal: Require rust 1.81 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants