Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide an config option to not set cfg(test) #18085

Merged
merged 2 commits into from
Sep 30, 2024
Merged

feat: Provide an config option to not set cfg(test) #18085

merged 2 commits into from
Sep 30, 2024

Commits on Sep 29, 2024

  1. Provide an config option to not set cfg(test)

    @ChayimFriedman2
    ChayimFriedman2 committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    4ea09dd View commit details
    Browse the repository at this point in the history

  2. Gate #[test] expansion under cfg(test). 

    This will mean users opting to not activate `cfg(test)` will lose IDE experience on them, which is quite unfortunate, but this is unavoidable if we want to avoid false positives on e.g. diagnostics. The real fix is to provide IDE experience even for cfg'ed out code, but this is out of scope for this PR.
    @ChayimFriedman2
    ChayimFriedman2 committed Sep 29, 2024
    Configuration menu
    Copy the full SHA
    4a06675 View commit details
    Browse the repository at this point in the history