Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Better testing infra for ratoml #18057

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

alibektas
Copy link
Member

This PR makes some improvements on how we test configs that come from rust-analyzer.toml files.
It was primarily used to solve #18021 but along the way I could not really determine the cause of the said issue which makes me think that it may not be related to the changes that I made earlier to the ratoml infra. In either way custom_snippets are now made global because we still don't have a tree that maps a SourceRootId to a set of Snippets.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2024
@Veykril
Copy link
Member

Veykril commented Sep 11, 2024

bors merge

@Veykril
Copy link
Member

Veykril commented Sep 11, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 11, 2024

📌 Commit 31ed8c9 has been approved by Veykril

It is now in the queue for this repository.

@Veykril Veykril changed the title Better testing infra for ratoml internal: Better testing infra for ratoml Sep 11, 2024
@bors
Copy link
Collaborator

bors commented Sep 11, 2024

⌛ Testing commit 31ed8c9 with merge 0267296...

@bors
Copy link
Collaborator

bors commented Sep 11, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 0267296 to master...

@bors bors merged commit 0267296 into rust-lang:master Sep 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants