fix: Wrong Self: Sized predicate for trait assoc items
#17948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
commented
Aug 23, 2024
| let get_trait_self_idx = |container: ItemContainerId| { | ||
| if matches!(container, ItemContainerId::TraitId(_)) { | ||
| let generics = generics(db.upcast(), def); | ||
| Some(generics.len_self()) |
There was a problem hiding this comment.
parent generics are comming after self ones
Veykril
approved these changes
Aug 23, 2024
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again while implementing object safety like #17939 😅
If we call
generic_predicates_queryonfn fooin the following code;It returns implicit bound
Self: Sized, even thoughSelfis not appearing as a generic parameter inside angle brackets, but as a parent generic parameter, "trait self".This PR prevent pushing "implicit"
Self: Sizedpredicates in such cases