editor/code: add option to suppress internal error notifications #15846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Nov 15, 2023
editors/code/src/lang_client.ts
Outdated
| import * as vscode from "vscode"; | ||
|
|
||
| export class RaLanguageClient extends lc.LanguageClient { | ||
| override error(message: string, data?: any, showNotification?: boolean | "force"): void { |
There was a problem hiding this comment.
Do you know what data might contain? Does it contain the error code by any chance? Would be nice if we could match on that instead, because then we can filter out some specific errors that VSCode raises (on non panicking requests) unconditionally (and log them instead).
There was a problem hiding this comment.
It seems like this is the ResponseError emitted by r-a, so it does contain the error code. I changed this to override handleRequestFailed instead of error, and set showNotification to false if we detect that it's an InternalError.
Co-authored-by: Lukas Wirth <[email protected]>
Veykril
approved these changes
Nov 24, 2023
|
@bors r+ |
Veykril
changed the title
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14193
rust-analyzer.showRequestFailedErrorNotificationconfiguration option, which defaults totruerust-analyzer.showRequestFailedErrorNotificationis set totrue, the current behavior is preserved.rust-analyzer.showRequestFailedErrorNotificationis set tofalse, no error toasts will be displayed for any of the failed requests caused by panics in r-a. This only applies to events that are triggered "implicitly", such astextDocument/hover.To test this, you can manually introduce a panic in one of the language server LSP handlers for non-command events. I added an explicit
panic!()in thetextDocument/hoverevent handler:rust-analyzer.showRequestFailedErrorNotificationset totrue(default)2023-11-07.17-17-48.webm
rust-analyzer.showRequestFailedErrorNotificationset tofalse2023-11-07.17-16-49.webm