Skip to content

Add basic tooltips to adjustment hints #13947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Jan 16, 2023
Merged

Add basic tooltips to adjustment hints #13947

bors merged 1 commit into from
Jan 16, 2023

Conversation

@WaffleLapkin
Copy link
Member

@WaffleLapkin WaffleLapkin commented Jan 14, 2023 •
edited
Loading

2023-01-16_16-45

I'm not sure how to make them look nicer, but it's at least something.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2023
@Veykril
Copy link
Member

Veykril commented Jan 14, 2023

This will probably need a rebase after #13946 is merged. Regarding making it look nicer, tooltips do support markdown (after #13946 there is a corresponding tooltip variant for markdown), so you could tinker with that.

@bors
Copy link
Contributor

bors commented Jan 14, 2023

☔ The latest upstream changes (presumably #13946) made this pull request unmergeable. Please resolve the merge conflicts.

@WaffleLapkin
Copy link
Member Author

WaffleLapkin commented Jan 14, 2023

It was perfect time for this PR wasn't it 😅

@Veykril Veykril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2023
@rust-cloud-vms rust-cloud-vms bot force-pushed the adjustment_hint_tooltips branch from 4ca1855 to 3b508a9 Compare January 16, 2023 12:38
@rust-cloud-vms rust-cloud-vms bot force-pushed the adjustment_hint_tooltips branch from 3b508a9 to 81d7e30 Compare January 16, 2023 12:44
@WaffleLapkin
Copy link
Member Author

WaffleLapkin commented Jan 16, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 16, 2023
@Veykril
Copy link
Member

Veykril commented Jan 16, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jan 16, 2023

📌 Commit 81d7e30 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 16, 2023

⌛ Testing commit 81d7e30 with merge 5306eb0...

@bors
Copy link
Contributor

bors commented Jan 16, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 5306eb0 to master...

@bors bors merged commit 5306eb0 into rust-lang:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@WaffleLapkin @Veykril @bors @rustbot