internal: fix a bunch of clippy lints

[danieleades]

fixes a bunch of clippy lints for fun and profit

i'm aware of this repo's position on clippy. The changes are split into separate commits so they can be reviewed separately

[bors]

☔ The latest upstream changes (presumably #13854) made this pull request unmergeable. Please resolve the merge conflicts.

[lnicola]

CC @nyurik looks like we got a bunch more of these, even after #13835. I wonder if the auto-fix got smarter.

[lnicola]

@bors r+

[bors]

📌 Commit bb083b8 has been approved by lnicola

It is now in the queue for this repository.

[bors]

⌛ Testing commit bb083b8 with merge f77b68a...

[danieleades]

CC @nyurik looks like we got a bunch more of these, even after #13835. I wonder if the auto-fix got smarter.

This repo's clippy policy means that there are a bunch of clippy lints being triggered. Clippy only reports a small number of hard errors before bailing early. If you fix the hard errors, clippy will report more warnings.

The autofix isn't smarter, I just addressed more of the other lints

[lnicola]

Clippy only reports a small number of hard errors before bailing early.

Ah, I didn't know that. So if you run cargo clippy --fix -- -A clippy::all -W clippy::uninlined_format_args multiple times, it will keep fixing things until there's no more uninlined_format_args? Interesting.

[lnicola]

Regarding clippy in general, if someone finds a set of "good" lints (without false positives or of questionable benefit), they can be added here and we'll be open to fixing them.

[bors]

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing f77b68a to master...