internal: Only run rainbow highlighting test on 64-bit Unix #12903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
mati865
reviewed
Aug 2, 2022
| @@ -915,6 +915,10 @@ fn main() { | |||
| } | |||
|
|
|||
| #[test] | |||
| #[cfg_attr( | |||
| all(unix, not(target_pointer_width = "64")), | |||
There was a problem hiding this comment.
Contrary to what title says this runs this test on UNIXes that are not 64-bit 😄
There was a problem hiding this comment.
🙀 no, it actually runs it on 32-bit non-Unix all non-Unix and all 64-bit targets.
There was a problem hiding this comment.
Oh, sorry I thought it's normal cfg. Didn't see that ignore part 🤦🏻♂️
There was a problem hiding this comment.
Well, it's still wrong 😀, thanks for spotting it.
bors
added a commit
that referenced
this pull request
Aug 7, 2022
Fix `test_rainbow_highlighting` gate CC #12903 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on the exact hash values, which is not exactly portable.