Skip to content

Fix const generic panic#11718

Merged
bors[bot] merged 1 commit intorust-lang:masterfrom
HKalbasi:const_generic
Mar 15, 2022
Merged

Fix const generic panic#11718
bors[bot] merged 1 commit intorust-lang:masterfrom
HKalbasi:const_generic

Conversation

@HKalbasi
Copy link
Member

@lnicola
Copy link
Member

lnicola commented Mar 15, 2022

bors r+

Merging this now to unblock the metrics.

@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

@bors bors bot merged commit fb9e66d into rust-lang:master Mar 15, 2022
@HKalbasi
Copy link
Member Author

Metrics is still broken, but for another reason I guess?

@lnicola
Copy link
Member

lnicola commented Mar 16, 2022

They don't crash any more for me, but I still get [ERROR hir_ty::consteval] is_unknown was called on a non-concrete constant value! ^0.0.

@HKalbasi
Copy link
Member Author

I still get [ERROR hir_ty::consteval] is_unknown was called on a non-concrete constant value! ^0.0.

I think it is fine for now. Current callers of is_unknown should be removed if I understand correctly, but it may miss some impls of arrays and keep it as-is is harmless. The tracing call can be removed.

And it seems metrics need some action: https://github.com/rust-analyzer/rust-analyzer/runs/5569046023?check_suite_focus=true

@lnicola
Copy link
Member

lnicola commented Mar 16, 2022

Yeah, that's #11724 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants