Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trait upcasting is not implemented yet #18083

Open
ShoyuVanilla opened this issue Sep 9, 2024 · 0 comments
Open

Trait upcasting is not implemented yet #18083

ShoyuVanilla opened this issue Sep 9, 2024 · 0 comments
Assignees
@ShoyuVanilla
Labels
A-ty type system / type inference / traits / method resolution C-bug Category: bug

Comments

@ShoyuVanilla
Copy link
Member

ShoyuVanilla commented Sep 9, 2024 •
edited
Loading

Miri also hits this incorrect diagnostics, in this line.

Originally posted by @RalfJung in #18047 (comment)
@ShoyuVanilla ShoyuVanilla self-assigned this Sep 9, 2024
@ShoyuVanilla ShoyuVanilla added A-ty type system / type inference / traits / method resolution C-bug Category: bug labels Sep 9, 2024
@ShoyuVanilla ShoyuVanilla changed the title Trait upcasting is not implemented Trait upcasting is not implemented yet Sep 9, 2024
@ShoyuVanilla ShoyuVanilla mentioned this issue Sep 10, 2024
Merged
bors added a commit that referenced this issue Sep 11, 2024
@bors
Auto merge of #18093 - ShoyuVanilla:skip-dyn-trait-cast-check, r=Veykril
dd026ce 
Skip checks for cast to dyn traits

It seems that chalk fails to solve some obvious goals when there are some recursiveness in trait environments.
And it doesn't support trait upcasting yet. rust-lang/chalk#796

This PR just skips for casting into types containing `dyn Trait` to prevent false positive diagnostics like #18047 and #18083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShoyuVanilla ShoyuVanilla

Labels
A-ty type system / type inference / traits / method resolution C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShoyuVanilla