Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code: support the new deprecated tag #1671

Closed
lnicola opened this issue Aug 9, 2019 · 5 comments · Fixed by #1931
Closed

Code: support the new deprecated tag #1671

lnicola opened this issue Aug 9, 2019 · 5 comments · Fixed by #1931

Comments

@lnicola
Copy link
Member

lnicola commented Aug 9, 2019

https://code.visualstudio.com/updates/v1_37#_diagnosticstagdeprecated

@lnicola lnicola changed the title Code: use the new deprecated tag Code: support the new deprecated tag Aug 9, 2019
@DJMcNab
Copy link
Contributor

DJMcNab commented Aug 10, 2019

This is not supported in the protocol - see microsoft/language-server-protocol#500. So this is currently waiting on upstream.

@lnicola
Copy link
Member Author

lnicola commented Sep 5, 2019

@kjeremy
Copy link
Contributor

kjeremy commented Sep 5, 2019

We already fill in the deprecated field on the LPS's SymbolInformation. I'm assuming the proposed extension API uses that?

@lnicola
Copy link
Member Author

lnicola commented Sep 5, 2019

vscode.languages.registerCompletionItemProvider('plaintext', {
  provideCompletionItems() {
    const item = new vscode.CompletionItem("deprecated_completion");
    item.tags = [vscode.CompletionItemTag.Deprecated];
    return [item];
  }
});

@kjeremy
Copy link
Contributor

kjeremy commented Sep 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants