Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Conversation

@matklad
Copy link
Contributor

@matklad matklad commented Jul 17, 2018

😞

@matklad
Copy link
Contributor Author

matklad commented Jul 17, 2018

bors try

@bors-voyager
Copy link
Contributor

bors-voyager bot commented Jul 17, 2018

🔒 Permission denied

Existing reviewers: click here to make matklad a reviewer

@matklad matklad mentioned this pull request Jul 17, 2018
@Xanewok
Copy link
Contributor

Xanewok commented Jul 17, 2018

@matklad wait, this disables/hijacks the regular CI or am I missing something?

bors try

bors-voyager bot added a commit that referenced this pull request Jul 17, 2018
@matklad
Copy link
Contributor Author

matklad commented Jul 17, 2018

@Xanewok bors-ng pushes commits to the stagin/trying branches, and uses the usual CI to test those branches, before promoting the master branch.

However, we should exclude the staging.tmp branch from CI, according to the docs. Fixed in #946

@matklad
Copy link
Contributor Author

matklad commented Jul 17, 2018

And, to clarify just in case, you can totally issue bors r+ before you see the CI checks on the PR pass. The PR checks are not used by bors when making merge decisions, they are needed just to give the PR author early feedback, and it would be valid to disable them completely.

@bors-voyager
Copy link
Contributor

bors-voyager bot commented Jul 17, 2018

@nrc nrc merged commit b7318f0 into rust-lang:master Jul 17, 2018
@matklad matklad deleted the update-clippy branch July 17, 2018 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants