This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Better symbol search #919
Merged
Better symbol search #919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Does this supersede #918 ? |
Contributor
Author
|
No, let’s merge that first and than I’lol rebase this branch. I’ve made changes on top of that branch just so I myself can use RLS which can both run tests and do fuzzy symbol search :) |
matklad
force-pushed
the
better-symbol-search
branch
from
ebf8c69 to
fbc4b85
Compare
Contributor
Author
|
Should be ready for the review. I've go a merge-conflict on the lockfile during rebase, so I regenerated it afresh. If neccessary, I can do this more cleanly and update only necessary deps in the lock. Or are we ok with updating the lock liberally? |
matklad
force-pushed
the
better-symbol-search
branch
from
fbc4b85 to
173794b
Compare
Contributor
Author
Unsurprisingly, this seems to have broken windows build :) Doing a concervative lockfile update now. |
Member
|
Sorry, merging #818 seems to have broken the lock file again |
matklad
force-pushed
the
better-symbol-search
branch
from
173794b to
db24fef
Compare
Merged
* uses fuzzy search instead of prefix matching * limits the number of results, so as to avoid freezing the IDE on an empty query
matklad
force-pushed
the
better-symbol-search
branch
from
db24fef to
f2bd01e
Compare
Contributor
Author
|
Conflicts resolved! |
Member
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RLS side of rust-dev-tools/rls-analysis#141