This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Use Inferrable for target/ config option #793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrc
reviewed
Mar 28, 2018
Member
nrc
left a comment
nrc
left a comment
There was a problem hiding this comment.
Looks good, a few comments inline
| return false; | ||
| } else { | ||
| return true; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Done. Let's, uh, not talk about previous, totally correct return false, though!
src/config.rs
Outdated
| return true; | ||
| } | ||
|
|
||
| return true; |
Member
There was a problem hiding this comment.
This looks wrong - it's essentially if ... { true } else { true }
Member
There was a problem hiding this comment.
And you don't need the final return
Member
|
Thanks! |
This was referenced Apr 2, 2018
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Apr 5, 2018
Update RLS Includes rust-lang/rls#793 which fixes rust-lang/rls#803.
This was referenced Nov 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #788.
First of all, it fixes target/rls dir (with #788 it reused the same dir as Cargo, oops!).
It now uses the
Inferrablewrapper, so it's possible to specify the value, set it to fallback and then re-set it again.Additionally it properly uses the relative passed dir (which slipped through in #788, I definitely need to do something about the tests 😟 ) now.
r? @nrc