This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Update rustfmt, pull in a few commits from the rustup branch
#1751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The ICE on Windows is interesting, though I feel like some of these cross-internal builds can be borderline pathological. Suspect it would be resolved with a bump of cargo and cargo-utils, any concerns with that? |
Contributor
|
☔ The latest upstream changes (presumably #1753) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Xanewok
Was originally just planning to bump the rustfmt reference to a more recent hash, but seems like some other changes/fixes hadn't made into the master branch either yet and so were pulled in as well