Remove needs-fcp label when an FCP is started#354
Merged
Conversation
Mark-Simulacrum
approved these changes
Jun 18, 2026
Mark-Simulacrum
left a comment
Mark-Simulacrum
left a comment
Member
There was a problem hiding this comment.
I'll try to get this deployed soon (when I have a bit of time after the deployment to monitor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since rust-lang/rust#157798, bors will refuse to approve a PR that has the
needs-fcplabel. Rfcbot should ideally remove the label when an FCP is started (since that time other labels will start blocking an approval), to avoid us having to remove it manually.More context: https://rust-lang.zulipchat.com/#narrow/channel/122651-general/topic/PR.20got.20merged.20without.20crater.20.26.20FCP/with/602913353