Use SparseSet-like structure for SuffixCache #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For simple regexes, allocating and filling 1000 of SuffixCache elements seemed to be quite high on the profile as part of Compiler::new, so I decided to optimise it by using ideas similar to sparse set, but specialised for a hashmap-like structure, instead of a flat array with versioning. In my performance comparisons this gives 8-10% improvement for simple regexes where overhead of Compiler::new is most noticeable.
|
FWIW I understand that SuffixCache is meant to be as simple as possible, but I think (hope) this change doesn't make it any more complicated while brings nice performance improvement. |
BurntSushi
approved these changes
Sep 9, 2018
|
@BurntSushi Seems to pass all the checks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For simple regexes, allocating and filling 1000 of SuffixCache elements seemed to be quite high on the profile as part of Compiler::new, so I decided to optimise it by using ideas similar to sparse set, but specialised for a hashmap-like structure, instead of a flat array with versioning.
In my performance comparisons this gives 8-10% improvement for simple regexes where overhead of Compiler::new is most noticeable.