-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build error with 1.3.8 (doc) #684
Comments
Caused by this change: f98eea5 |
This ticket isn't actionable. I see no way to reproduce it. I don't see which version of Rust you're using nor which commands you've run. Could you please provide enough details to reproduce the problem? |
This was stabilized in |
|
It relies on `cfg(doctest)`, which wasn't stabilized until Rust 1.43. Interestingly, it compiled on Rust 1.28, but didn't compile on, e.g., Rust 1.39. This breaks our MSRV policy, so we unfortunately remove the use of doc_comment for now. It's likely possible to conditionally enable it, but the extra build script required to do version sniffing to do it doesn't seem worth it. Fixes #684, Fixes #685
This was an interesting issue, but it is now fixed!
|
Perfect timing, I was just now able to restore access to the Dockerfile that included the rust compiler and indeed it was 1.39 😄 Glad you were able to find it despite the lack of info. |
This crate is used somewhere in the dep tree of a package I need (tokei). It seems like the latest update broke the build for my current rust version (it did work a few hours ago). I'll investigate, but this is what's happening:
The text was updated successfully, but these errors were encountered: