Add reference for attributes in function parameters #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
reviewed
Aug 22, 2019
This comment has been minimized.
This comment has been minimized.
Centril
reviewed
Aug 26, 2019
Closed
|
Due to a blunder on my part, I did not see that this had already been done. Can you carry over some of the additional changes from #682 over here? In particular:
|
|
@ehuss I will do the additional modifications in this weekend |
c410-f3r
force-pushed
the
attrs-fn
branch
2 times, most recently
from
21da765
to
77e2be2
Compare
|
Updated |
ehuss
reviewed
Sep 30, 2019
| ## Attributes on function parameters | ||
|
|
||
| [Outer attributes][attributes] are allowed on function parameters and the | ||
| permitted [built-in attributes] are restricted to `cfg`, `cfg_attr`, `allow`, |
There was a problem hiding this comment.
I think it would be good to be clearer about exactly which attributes are allowed, since this doesn't mention that (active) proc macros are forbidden. As Centril pointed out in the release notes (and which took me a while to grok until I read rust-lang/rust#63210), that inert helper attributes are allowed. I'm not sure how to word that clearly.
|
Ping @c410-f3r, do you think you'll be able to update for the changes requested above? |
|
Omg! Sorry for the delay |
ehuss
reviewed
Oct 18, 2019
src/items/functions.md
Outdated
| Inert helper attributes used by procedural macro attributes applied to items are also | ||
| allowed but be careful to not include these inert attributes in your final `TokenStream`. | ||
|
|
||
| ```rust |
There was a problem hiding this comment.
Suggested change
| ```rust | |
| ```rust,ignore |
This doesn't pass the tests because the attribute isn't defined.
src/items/functions.md
Outdated
|
|
||
| ```rust | ||
| #[hi_i_am_a_proc_macro_attribute] | ||
| fn foo_oof(#[hello_i_am_an_inert_attribute] arg: u8) { |
There was a problem hiding this comment.
Maybe add a comment explaining what this is trying to illustrate? Maybe something like this:
// This inert attribute is not formally defined anywhere. The
// `hi_i_am_a_proc_macro_attribute` proc macro is responsible for detecting
// its presence and removing it from the output token stream.
|
@ehuss Thank you |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Oct 30, 2019
Update cargo, books. ## cargo 8 commits in 3ba5f27170db10af7a92f2b682e049397197b8fa..5da4b4d47963868d9878480197581ccbbdaece74 2019-10-22 15:05:18 +0000 to 2019-10-28 21:53:41 +0000 - Add --filter-platform to `cargo metadata`. (rust-lang/cargo#7376) - Fix `cargo fix` not showing colors. (rust-lang/cargo#7550) - Rephrase --manifest-path section (rust-lang/cargo#7409) - Add a note to discourage the use of -Zminimal-versions. (rust-lang/cargo#7549) - Fix profile override warning in a workspace. (rust-lang/cargo#7536) - Fix some tests failing on Windows nightly. (rust-lang/cargo#7534) - Show better error message for Windows abnormal termination. (rust-lang/cargo#7535) - Run `apt update` before `apt install` (rust-lang/cargo#7541) ## reference 8 commits in 5b9d2fc..4b21b64 2019-10-03 22:39:10 +0200 to 2019-10-27 22:33:11 +0100 - Document `const_constructor` feature (rust-lang/reference#677) - Add `non_exhaustive` to reference. (rust-lang/reference#609) - Re-add rust-docs component for lintcheck (rust-lang/reference#702) - group signed and unsigned integers in layout table (rust-lang/reference#700) - Fix layout table rendering (rust-lang/reference#699) - Add reference for attributes in function parameters (rust-lang/reference#657) - Update now that proc macros can expand to macro_rules. (rust-lang/reference#694) - Fix match in union example. (rust-lang/reference#684) ## book 8 commits in 9bb8b161963fcebc9d9ccd732ba26f42108016d5..28fa3d15b0bc67ea5e79eeff2198e4277fc61baf 2019-10-14 18:42:55 -0500 to 2019-10-29 07:16:09 -0500 - Update Ch19.1 on slice splitting (rust-lang/book#1999) - fixed inconsistent terminology regarding enums (rust-lang/book#2022) - Update ch15-03 code to match output. (rust-lang/book#2020) - Fixes rust-lang/book#2039 (rust-lang/book#2040) - Update ch15-03-drop.md (rust-lang/book#2049) - unit type value is also a value (rust-lang/book#2061) - Minor: remove an extraneous `.` (rust-lang/book#2059) - Clarifications and consistent use of quotation marks (rust-lang/book#1992) ## rust-by-example 4 commits in 0b111eaae36cc4b4997684be853882a59e2c7ca7..f3197ddf2abab9abdbc029def8164f4a748b0d91 2019-10-14 18:34:25 -0300 to 2019-10-29 10:17:40 -0300 - Fix typos (rust-lang/rust-by-example#1285) - Improve Cargo / Dependencies section (rust-lang/rust-by-example#1287) - Improve Cargo / Build Scripts section (rust-lang/rust-by-example#1288) - Make if_let exercise runnable (rust-lang/rust-by-example#1289)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this PR shouldn't be added before stabilization but for now it is publicly available for review