Mention tool lint attributes

[Manishearth]

Being stabilized in rust-lang/rust#54870 , wanted to preserve some documentation. Clippy has more docs on this.

r? @steveklabnik

[matthewjasper]

extra new line

[Manishearth]

fixed

[Havvy]

This is okay as is. Don't take the rest of what I'm saying as a requirement to make changes, although do tell me if you want to make them. Otherwise, we can merge this as is (though it'd be nice to know Travis will pass...).

With that out of the way, I think that tool lints don't need their own section. Instead, we need a more general section on lint check values that says both identifiers and ident:ident is valid. We should also probably have a grammar for these attributes, like I added for cfg_attr and cfg in #444. That we don't say that the lint names must be valid identifiers is an oversight I did not notice until you posted this PR.

[Manishearth]

Slightly feel they should be in their own section, since the conditional checking of tool lints is important, prefer to merge as-is.

Added an ignore to the test since this is nightly-only right now (stabilized, but hasn't yet reached stable)

[Havvy]

One nit before I merge: Everything in the parenthesis should not be in the header.

[Manishearth]

done -Manish Goregaokar

…

On Mon, Oct 15, 2018 at 11:36 PM Ryan Scheel ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/attributes.md <#446 (comment)> : > @@ -357,6 +357,35 @@ pub mod m3 { } ``` +#### Tool lint attributes (`#[allow(clippy::foo)]`) One nit before I merge: Everything in the parenthesis should not be in the header. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#446 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABivSMC47-PD4eVlvUciUAK0L6Wa4Mhsks5ulX6BgaJpZM4XUVED> .

[Havvy]

💟 Thanks!