Add review process overview to review-policy.md #2088
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This text is great. Jane put this together after talking with the team in some detail in a lang-docs office hours call. In this commit, we revise the wording slightly and adjust capitalization to match our style.
traviscross
force-pushed
the
review-process-overview
branch
from
33f3a37 to
81ed7c1
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
traviscross
approved these changes
Nov 18, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This section slightly duplicates the text below. In the review flowchart, this policy already discusses "checking if the content is true," which I feel corresponds to the defensibility goal, and the "is this editorially sound" and "is this well written," which I think are aimed more directly at reviewers and ensuring they bring a consistent tone to the contribution pre-merge. Understandability isn't explicitly mentioned in the policy, afaict.
With this new section, I wanted to speak more to both reviewers and authors, including subject-matter reviewers who aren't necessarily bringing the editorial expertise to help set better expectations for how the back-and-forth of the review process is expected to work. As part of that, I wanted to explain the underlying rationale for these goals/principles of the review process. I'm not really sure the voice one fits in as it's currently structured, since it's sort of a goal/non-goal depending on who the reader is, but this seemed good enough for a first pass.