Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic runtime and C-unwind documentation #1226
panic runtime and C-unwind documentation #1226
Changes from all commits
5f63e46
c8fc0e8
edd5b18
39de76c
6413901
70f8292
d08e406
a20802e
2525ab4
5bff1e3
7453efd
c3cc7fa
860691e
543bc27
4bb0248
386b2f3
c7a7961
20af0b1
da53531
8fd8208
0f3c015
63677c1
caa17fc
0b37538
eafe95d
5f21a1a
79cc53f
c38044d
20bd38f
f309b2f
2617cd5
d49c90c
6eaa1fa
a740002
f7cb25e
34e0b68
8f4dc2b
6e76b5c
7049886
003a8a4
cdd00de
ffc056c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For (*1), I am relying on rust-lang/rust#52652 (comment) .
For (*2), an alternative would be to make the point at which the abort occurs for
panic=abort
unspecified, except that it must occur at the latest when the unwind reaches a Rust frame. But I don't think it is necessary to weaken the spec in that way given the intended implementation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know that the way aborts are implemented guarantees that on all platforms for point 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that's part of rust-lang/rust#123231.