New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grammar for new genaric arg syntax #785

Closed

ehuss opened this issue Apr 2, 2020 · 0 comments · Fixed by #920

Labels

A-grammar

Contributor

ehuss commented Apr 2, 2020

Grammar needs to be updated for the changes in rust-lang/rust#70261. I think the changes would go around here: https://github.com/rust-lang/reference/blob/master/src/paths.md#paths-in-expressions

ehuss added the A-grammar label

ehuss mentioned this issue

Simplify rules for GenericArgs nonterminal and other small improvements and fixes #805

Closed

ehuss mentioned this issue

document const generics #901

Merged

ehuss added a commit to ehuss/reference that referenced this issue


          Update grammar for order of parameters/arguments.

8511cf4

Generic param order restriction was changed in rust-lang/rust#58191.
Generic argument order restriction was changed in rust-lang/rust#70261.
`for` lifetime argument restriction was changed in rust-lang/rust#48326.

Generic parameter parsing: https://github.com/rust-lang/rust/blob/206ee1eea3467fd1d7f1efdbeafe27880897bb2c/compiler/rustc_parse/src/parser/generics.rs#L83-L153
Generic argument parsing: https://github.com/rust-lang/rust/blob/17eec1433c69972844dd228b5fe801f218e118c3/compiler/rustc_parse/src/parser/path.rs#L395-L413
`for` argument parsing: https://github.com/rust-lang/rust/blob/206ee1eea3467fd1d7f1efdbeafe27880897bb2c/compiler/rustc_parse/src/parser/ty.rs#L724-L736

Fixes rust-lang#785

ehuss mentioned this issue

Update grammar for order of parameters/arguments. #920

Merged

Havvy closed this as completed in #920

wsh pushed a commit to wsh/rust-reference that referenced this issue


          Update grammar for order of parameters/arguments.

d79ee62

Generic param order restriction was changed in rust-lang/rust#58191.
Generic argument order restriction was changed in rust-lang/rust#70261.
`for` lifetime argument restriction was changed in rust-lang/rust#48326.

Generic parameter parsing: https://github.com/rust-lang/rust/blob/206ee1eea3467fd1d7f1efdbeafe27880897bb2c/compiler/rustc_parse/src/parser/generics.rs#L83-L153
Generic argument parsing: https://github.com/rust-lang/rust/blob/17eec1433c69972844dd228b5fe801f218e118c3/compiler/rustc_parse/src/parser/path.rs#L395-L413
`for` argument parsing: https://github.com/rust-lang/rust/blob/206ee1eea3467fd1d7f1efdbeafe27880897bb2c/compiler/rustc_parse/src/parser/ty.rs#L724-L736

Fixes rust-lang#785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment