Skip to content

Conversation

@rami3l
Copy link
Member

@rami3l rami3l commented Dec 22, 2025

Mirrors rust-lang/rust#150289.

Similarly, as I'm new here, please feel free to point out any inconsistencies or any extra work I'll need to do to fully land this somewhat breaking change, including the order of merges, etc.

@rami3l rami3l force-pushed the patch-1 branch 2 times, most recently from 89003b9 to a755b4d Compare December 23, 2025 10:31
@rami3l rami3l marked this pull request as ready for review December 23, 2025 14:34
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should work and should be safe to land independently of the rust-lang/rust PR with the change. If that aligns with your understanding I'm happy to merge this ~whenever and we can confirm it works on the next nightly release, and then merge the rust-lang/rust PR after that.

@Mark-Simulacrum Mark-Simulacrum enabled auto-merge (rebase) December 28, 2025 18:03
@Mark-Simulacrum Mark-Simulacrum merged commit 2c6837e into rust-lang:master Dec 28, 2025
6 checks passed
@rami3l rami3l deleted the patch-1 branch December 28, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants