This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Refactoring HIR Place: Fields #2
Comments
6 tasks
arora-aman
added a commit
to sexxi-goose/rust
that referenced
this issue
Jul 7, 2020
This commit also categorizing access as Field, Index, or Subslice. Ideas are taken from `mir::ProjectionElem`. Proposed changes: https://github.com/rust-lang/project-rfc-2229/blob/master/hir-place-target.md Closes: rust-lang/project-rfc-2229#1, rust-lang/project-rfc-2229#2 Co-authored-by: Aman Arora <[email protected]> Co-authored-by: Chris Pardy <[email protected]> Co-authored-by: Dhruv Jauhar <[email protected]>
arora-aman
added a commit
to sexxi-goose/rust
that referenced
this issue
Jul 7, 2020
This commit also categorizing access as Field, Index, or Subslice. Ideas are taken from `mir::ProjectionElem`. Proposed changes: https://github.com/rust-lang/project-rfc-2229/blob/master/hir-place-target.md Closes: rust-lang/project-rfc-2229#1, rust-lang/project-rfc-2229#2 Co-authored-by: Aman Arora <[email protected]> Co-authored-by: Chris Pardy <[email protected]> Co-authored-by: Dhruv Jauhar <[email protected]>
arora-aman
added a commit
to sexxi-goose/rust
that referenced
this issue
Jul 8, 2020
This commit also categorizing access as Field, Index, or Subslice. Ideas are taken from `mir::ProjectionElem`. Proposed changes: https://github.com/rust-lang/project-rfc-2229/blob/master/hir-place-target.md Closes: rust-lang/project-rfc-2229#1, rust-lang/project-rfc-2229#2 Co-authored-by: Aman Arora <[email protected]> Co-authored-by: Chris Pardy <[email protected]> Co-authored-by: Dhruv Jauhar <[email protected]>
arora-aman
added a commit
to sexxi-goose/rust
that referenced
this issue
Jul 9, 2020
This commit also categorizing access as Field, Index, or Subslice. Ideas are taken from `mir::ProjectionElem`. Proposed changes: https://github.com/rust-lang/project-rfc-2229/blob/master/hir-place-target.md Closes: rust-lang/project-rfc-2229#1, rust-lang/project-rfc-2229#2 Co-authored-by: Aman Arora <[email protected]> Co-authored-by: Chris Pardy <[email protected]> Co-authored-by: Dhruv Jauhar <[email protected]>
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Jul 16, 2020
…, r=nikomatsakis Make hir ProjectionKind more precise This commit also categorizing access as Field, Index, or Subslice. Ideas are taken from `mir::ProjectionElem`. Proposed changes: https://github.com/rust-lang/project-rfc-2229/blob/master/hir-place-target.md Closes: rust-lang/project-rfc-2229#1, Closes: rust-lang/project-rfc-2229#2 r? @nikomatsakis @matthewjasper
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Jul 16, 2020
…, r=nikomatsakis Make hir ProjectionKind more precise This commit also categorizing access as Field, Index, or Subslice. Ideas are taken from `mir::ProjectionElem`. Proposed changes: https://github.com/rust-lang/project-rfc-2229/blob/master/hir-place-target.md Closes: rust-lang/project-rfc-2229#1, Closes: rust-lang/project-rfc-2229#2 r? @nikomatsakis @matthewjasper
Manishearth
added a commit
to Manishearth/rust
that referenced
this issue
Jul 16, 2020
…, r=nikomatsakis Make hir ProjectionKind more precise This commit also categorizing access as Field, Index, or Subslice. Ideas are taken from `mir::ProjectionElem`. Proposed changes: https://github.com/rust-lang/project-rfc-2229/blob/master/hir-place-target.md Closes: rust-lang/project-rfc-2229#1, Closes: rust-lang/project-rfc-2229#2 r? @nikomatsakis @matthewjasper
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As part of #1, one of the first steps would be to extract out a "Field" projection for HIR Places.
To make this change, we would start by extending the definition of
Projectionwith a new variant,Field, based on the MIR variant.XXX add more details
The text was updated successfully, but these errors were encountered: