Conversation
|
quite a lot of the library assumes the max lane count is 64, at the very least basically all the tests that only test up to 64 lanes should also test more than 64 lanes. also the bitmasks code uses |
|
getting all the tests to pass with 128 lanes is going to be a lot of work and be somewhat controversial (though we do want to increase the limit to more than 128 at some point), so if you want this PR to have a good chance of getting merged quickly, I'd suggest leaving out the change to 128 lanes and maybe just have the 1 byte x 128 lanes hexagon types be commented out for now with a fixme to re-enable them when we get around to adding support for >64 lanes. |
Would it be a good idea for me to create an MCP?
I'm not in a hurry.
Sounds good to me: will do. |
7c57d0b to
06629e0
Compare
|
BTW: not sure if I understood the goal of the checklist but 3e0f44c |
It's probably not necessary.
the checklist is more for if you were adding new functions like |
Ok so should I drop 3e0f44c ? Seems like it's not necessary. |
it isn't necessary for this PR. |
06629e0 to
0ebaab0
Compare
|
Sorry: I misunderstood how this crate gets integrated - I will need to land rust-lang/stdarch#1999 first and then re-evaluate the design of HVX in portable-simd after that. Closing. |
Add support for HVX, omitting support for 128-lane for now.