Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for https://github.com/rust-lang/rust/pull/42959 #32

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

SimonSapin
Copy link
Contributor

No description provided.

@Gankra
Copy link
Contributor

Gankra commented Jul 14, 2017

ping me when this is ready to land

@SimonSapin
Copy link
Contributor Author

I suppose we still have to figure out which parts of #42959 are desired. In the meantime, could you push this to a branch of this repo so that https://travis-ci.org/rust-lang/rust/jobs/253789889 doesn’t fail to update the submodule?

@Gankra
Copy link
Contributor

Gankra commented Jul 14, 2017

uhh is it possible for you to submit the PR to a branch?

@SimonSapin
Copy link
Contributor Author

Yes, but a branch other than master needs to exist first.

Or you can do something like git fetch origin pull/32/head && git push origin FETCH_HEAD:nonzero-checked

@Gankra
Copy link
Contributor

Gankra commented Jul 14, 2017

if only there were SOME WAY to not have to deal with circular dependencies..........................

@Gankra
Copy link
Contributor

Gankra commented Jul 14, 2017

@Gankra
Copy link
Contributor

Gankra commented Aug 2, 2017

#33 is the replacement for this

@Gankra Gankra closed this Aug 2, 2017
@Gankra Gankra reopened this Aug 2, 2017
@Gankra
Copy link
Contributor

Gankra commented Aug 2, 2017

something something need to merge this to master properly

@Gankra Gankra merged commit 680e284 into rust-lang:master Aug 2, 2017
@SimonSapin SimonSapin deleted the nonzero-checked branch August 2, 2017 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants