Skip to content

test: update cross-namespace diagnostic#5214

Closed
TorinAsakura wants to merge 1 commit into
rust-lang:masterfrom
TorinAsakura:test/update-cross-namespace-diagnostic
Closed

test: update cross-namespace diagnostic#5214
TorinAsakura wants to merge 1 commit into
rust-lang:masterfrom
TorinAsakura:test/update-cross-namespace-diagnostic

Conversation

@TorinAsakura

@TorinAsakura TorinAsakura commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Task

How to test

Before the fix

  1. Context: Miri after Improve cross-namespace name diagnostics rust#159307 is included in rust-version
    Action: run tests/fail/rustc-error.rs
    Expected result: the old expectations do not match the rustc diagnostic

After the fix

  1. Context: Miri after Improve cross-namespace name diagnostics rust#159307 is included in rust-version
    Action: run tests/fail/rustc-error.rs
    Expected result: the test accepts the new diagnostic, the note about the macro in another namespace, and the macro invocation suggestion

Proof

  • Only tests/fail/rustc-error.rs and tests/fail/rustc-error.stderr are changed
  • The targeted Miri run in the Rust PR passed: rust-lang/rust@61730f7
  • Miri's current rust-version predates the Rust PR, so the local Miri UI run cannot exercise the new expectation yet

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Jul 17, 2026
@oli-obk

oli-obk commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

If there are rustc changes needed we land it in rustc together with those changes

@oli-obk oli-obk closed this Jul 17, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Waiting for a review to complete label Jul 17, 2026
@TorinAsakura
TorinAsakura deleted the test/update-cross-namespace-diagnostic branch July 17, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants