test: update cross-namespace diagnostic#5214
Closed
TorinAsakura wants to merge 1 commit into
Closed
Conversation
Contributor
|
If there are rustc changes needed we land it in rustc together with those changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
startorpathrust#86290How to test
Before the fix
Action: run tests/fail/rustc-error.rs
Expected result: the old expectations do not match the rustc diagnostic
After the fix
Action: run tests/fail/rustc-error.rs
Expected result: the test accepts the new diagnostic, the note about the macro in another namespace, and the macro invocation suggestion
Proof