Scope CI permissions to the job that needs it #3909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! I did not know you can scope permissions. Now <#3908> already landed, which conflicts. Could you rebase, and also keep the comments that my PR added?
|
Kobzol
force-pushed
the
ci-permissions
branch
from
88f0521 to
a164b85
Compare
Member
Author
|
Done. But I would suggest waiting before merging this, until we confirm that |
Kobzol
changed the title
Member
|
This seems strictly better than what we have in-tree currently, so I think we should just land it and see what happens tomorrow morning. @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I scoped the permissions only to the job that requires them.