InitOnce: synchronize with completion when already complete #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Oct 31, 2022
RalfJung
reviewed
Oct 31, 2022
RalfJung
reviewed
Oct 31, 2022
RalfJung
reviewed
Oct 31, 2022
RalfJung
reviewed
Oct 31, 2022
RalfJung
reviewed
Oct 31, 2022
|
Thanks, looks good! |
|
☀️ Test successful - checks-actions |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 11, 2022
update Miri Notable PRs: - rust-lang/miri#2636 - rust-lang/miri#2641 - rust-lang/miri#2638
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Nov 15, 2022
update Miri Notable PRs: - rust-lang#2636 - rust-lang#2641 - rust-lang#2638
spikespaz
pushed a commit
to spikespaz/dotwalk-rs
that referenced
this pull request
Aug 29, 2024
update Miri Notable PRs: - rust-lang/miri#2636 - rust-lang/miri#2641 - rust-lang/miri#2638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The completion of an InitOnce happens-before the threads waiting on it wake up. However, this is not the case for threads that call
InitOnceBeginInitializeafter the completion, leading to data races and outdated weak memory loads as observed in the CI for #2638. This PR fixes this.