split flag section into common and advanced flags #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
May 23, 2022
oli-obk
reviewed
May 23, 2022
| **NOTE**: This entropy is not good enough for cryptographic use! Do not | ||
| generate secret keys in Miri or perform other kinds of cryptographic | ||
| operations that rely on proper random numbers. | ||
| * `-Zmiri-strict-provenance` enables [strict |
There was a problem hiding this comment.
Is this common at present, seems experimental. Once it leaves experimental mode, we should probably switch to it by default and add a disable flag. Though seems ok here for visibility
There was a problem hiding this comment.
I don't think strict-provenance should be the default, see #2133.
oli-obk
approved these changes
May 23, 2022
|
@bors r+ |
|
📌 Commit 4d9eafe has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @oli-obk . However I was not always sure which flags to put where, so if you think some flags should be in the other category please let me know. :)