Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for #[no_mangle] on associated functions #1871

Merged
merged 1 commit into from Aug 15, 2021
Merged

Update tests for #[no_mangle] on associated functions #1871

merged 1 commit into from Aug 15, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 15, 2021

rust-lang/rust#86492 has landed:

  • The code in #[no_mangle] on associated functions #1837 starts to work (even without AssocFn::foo(); at line 12) in Miri.
  • pub is not necessary for #[no_mangle] associated functions in test-cargo-miri/exported-symbol-dep/src/lib.rs anymore.

Closes #1837.

@RalfJung
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 15, 2021

📌 Commit 838ed1d has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented Aug 15, 2021

⌛ Testing commit 838ed1d with merge e8ac524...

@bors
Copy link
Collaborator

bors commented Aug 15, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing e8ac524 to master...

@bors bors merged commit e8ac524 into rust-lang:master Aug 15, 2021
@ghost ghost deleted the no-mangle-method branch August 16, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#[no_mangle] on associated functions
2 participants