Skip to content

Conversation

@RalfJung
Copy link
Member

@oli-obk I am not sure if anyone used this program in the last few years. There are no instructions for how to use it. So I think keeping it working is just a waste of time. It now fails to build:

error[E0046]: not all trait items implemented, missing: `visit_foreign_item`
  --> src/bin/miri-rustc-tests.rs:36:17
   |
36 |                 impl<'tcx, 'hir> itemlikevisit::ItemLikeVisitor<'hir> for Visitor<'tcx> {
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `visit_foreign_item` in implementation

So I propose instead of me trying to figure out how to fix this, we just drop this ancient code.

@oli-obk
Copy link
Contributor

oli-obk commented Nov 30, 2020

@bors r+

yea, I don't plan on reviving it

@bors
Copy link
Contributor

bors commented Nov 30, 2020

📌 Commit 6145709 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Nov 30, 2020

⌛ Testing commit 6145709 with merge 47acece...

@bors
Copy link
Contributor

bors commented Nov 30, 2020

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 47acece to master...

@bors bors merged commit 47acece into rust-lang:master Nov 30, 2020
@RalfJung RalfJung deleted the rustup branch December 5, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants