Propagate the return code from the start lang item
#1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang#1064 This ensures that we set the error code properly when a panic unwinds past `main`. I'm not sure what the best way to write a test for this is
RalfJung
reviewed
Nov 20, 2019
RalfJung
reviewed
Nov 20, 2019
Don't explicitly exit if we reported an evaluation error
|
@RalfJung: Updated |
RalfJung
reviewed
Nov 20, 2019
RalfJung
reviewed
Nov 20, 2019
Co-Authored-By: Ralf Jung <[email protected]>
|
@RalfJung: Updated |
|
Thanks! @bors r+ |
|
📌 Commit 2176bf6 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 20, 2019
Propagate the return code from the `start` lang item Fixes #1064 This ensures that we set the error code properly when a panic unwinds past `main`. I'm not sure what the best way to write a test for this is
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1064
This ensures that we set the error code properly when a panic unwinds
past
main.I'm not sure what the best way to write a test for this is