Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wide pointer metadata validity: check that the vtable is for the right trait #3497

Closed
RalfJung opened this issue Apr 21, 2024 · 0 comments · Fixed by rust-lang/rust#124220
Closed
Labels
I-misses-UB Impact: makes Miri miss UB, i.e., a false negative (with default settings)

Comments

@RalfJung
Copy link
Member

With rust-lang/rust#123572, rustc started assuming for UB purposes that a vtable pointer points to a vtabe that's sufficiently big for the given trait. Miri currently isn't able to check that UB.

@RalfJung RalfJung added the I-misses-UB Impact: makes Miri miss UB, i.e., a false negative (with default settings) label Apr 21, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Apr 22, 2024
…=oli-obk

Miri: detect wrong vtables in wide pointers

Fixes rust-lang/miri#3497.
Needed to catch the UB that rust-lang#123572 will start exploiting.

r? `@oli-obk`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Apr 22, 2024
…=oli-obk

Miri: detect wrong vtables in wide pointers

Fixes rust-lang/miri#3497.
Needed to catch the UB that rust-lang#123572 will start exploiting.

r? ``@oli-obk``
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Apr 23, 2024
Rollup merge of rust-lang#124220 - RalfJung:interpret-wrong-vtable, r=oli-obk

Miri: detect wrong vtables in wide pointers

Fixes rust-lang/miri#3497.
Needed to catch the UB that rust-lang#123572 will start exploiting.

r? `@oli-obk`
github-actions bot pushed a commit that referenced this issue Apr 24, 2024
Miri: detect wrong vtables in wide pointers

Fixes #3497.
Needed to catch the UB that rust-lang/rust#123572 will start exploiting.

r? `@oli-obk`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-misses-UB Impact: makes Miri miss UB, i.e., a false negative (with default settings)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant