Test stdarch (only x86 SSE and SSE2 for now) #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardosm
force-pushed
the
test-stdarch
branch
2 times, most recently
from
ff48859 to
2144884
Compare
RalfJung
reviewed
Sep 29, 2023
|
This looks great, thanks a lot. :) |
RalfJung
reviewed
Sep 29, 2023
| TEST_ARGS=( | ||
| core_arch::x86::{sse,sse2}:: | ||
| core_arch::x86_64::{sse,sse2}:: | ||
| # FIXME add `#[cfg_attr(miri, ignore)]` to those tests in stdarch |
There was a problem hiding this comment.
Suggested change
| # FIXME add `#[cfg_attr(miri, ignore)]` to those tests in stdarch | |
| # FIXME add `#[cfg_attr(miri, ignore)]` to those tests in stdarch | |
| # These are nontemporal stores, fences, and CSR (FP env status register) accesses |
RalfJung
reviewed
Sep 29, 2023
run-stdarch-test.sh
Outdated
| --skip test_mm_stream_ps | ||
| --skip test_mm_clflush | ||
| --skip test_mm_lfence | ||
| --skip test_mm_madd_epi16 # FIXME not yet implemented |
There was a problem hiding this comment.
This one looks like it should be outside the "FIXME add #[cfg_attr(miri, ignore)] to those tests in stdarch"?
eduardosm
force-pushed
the
test-stdarch
branch
from
2144884 to
ed6b098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc rust-lang/miri#3088