Skip to content

Commit

Permalink
Remove filtering of tests
Browse files Browse the repository at this point in the history
  • Loading branch information
tgross35 committed Oct 6, 2023
1 parent 8711457 commit 8f89583
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 19 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/ci-sanitizers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,18 @@ jobs:
# continue running if other tests fail. Disable this once we get out of the
# prototype phase
if: always()
timeout-minutes: 60
steps:
- uses: actions/checkout@v3
- name: Setup environment
run: bash ./ci-sanitizers-setup.sh
- name: Run ${{ matrix.sanitizer }}
- name: Run ${{ matrix.sanitizer }} sanitizer
# Mark everything as pass just so GH doesn't cancel on us as soon as there is a failure
run: ./ci-sanitizers-test.sh ${{ matrix.crate }} ${{ matrix.sanitizer }} && echo 'good!' || echo 'fail!''
mark_failure:
runs-on: ubuntu-latest
steps:
- run: sleep 2000 && echo that's enough 'time!'; exit 1
- run: sleep 2000 && echo 'that is enough time!'; exit 1

# Send a Zulip notification when a cron job fails
# cron-fail-notify:
Expand Down
24 changes: 7 additions & 17 deletions ci-sanitizers-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ memtag)
cfi)
# CFI needs LTO and 1CGU, seems like randomize-layout enables `embed-bitcode=no`
# which conflicts
RUSTFLAGS="${RUSTFLAGS} -Zsanitizer=cfi -Clto -Cembed-bitcode=yes -Ccodegen-units=1"
RUSTFLAGS="${RUSTFLAGS} -Zsanitizer=cfi -Cembed-bitcode=yes -Ccodegen-units=1"
;;
kcfi)
RUSTFLAGS="${RUSTFLAGS} -Zsanitizer=kcfi"
Expand Down Expand Up @@ -81,7 +81,8 @@ echo "Running tests with on target $TARGET with flags '$RUSTFLAGS'"
case "$1" in
core)
echo "::group::Testing core"
./sanitizers-run-test.sh core --target "$TARGET" --lib --tests -- --skip align \
# ./sanitizers-run-test.sh core --target "$TARGET" --lib --tests -- --skip align \
./sanitizers-run-test.sh core --target "$TARGET" --lib --tests \
2>&1 | ts -i '%.s '
echo "::endgroup::"

Expand All @@ -108,33 +109,22 @@ alloc)
;;
std)
# Modules that we skip entirely, because they need a lot of shims we don't support.
SKIP="fs:: net:: process:: sys:: sys_common::net::"
# SKIP="fs:: net:: process:: sys:: sys_common::net::"
# Core modules, that we are testing on a bunch of targets.
# These are the most OS-specific (among the modules we do not skip).
CORE="time:: sync:: thread:: env::"
# CORE="time:: sync:: thread:: env::"

echo "::group::Testing std core"
./sanitizers-run-test.sh std --target "$TARGET" --lib --tests -- "$CORE" \
./sanitizers-run-test.sh std --target "$TARGET" --lib --tests -- \
2>&1 | ts -i '%.s '
echo "::endgroup::"

echo "::group::Testing std core docs"
./sanitizers-run-test.sh std --target "$TARGET" --doc -- "$CORE" \
./sanitizers-run-test.sh std --target "$TARGET" --doc -- \
2>&1 | ts -i '%.s '
echo "::endgroup::"

# "sleep" has a thread leak that we have to ignore
echo "::group::Testing remaining std (all except for $SKIP)"
./sanitizers-run-test.sh std --lib --tests \
2>&1 | ts -i '%.s '
# -- $(for M in $CORE; do echo "--skip $M "; done) $(for M in $SKIP; do echo "--skip $M "; done) \
echo "::endgroup::"

echo "::group::Testing remaining std docs (all except for $SKIP)"
./sanitizers-run-test.sh std --doc \
2>&1 | ts -i '%.s '
# -- $(for M in $CORE; do echo "--skip $M "; done) $(for M in $SKIP; do echo "--skip $M "; done) \
echo "::endgroup::"
;;
simd)
cd "$LIB_SRC/portable-simd"
Expand Down

0 comments on commit 8f89583

Please sign in to comment.