Fix default theme dir selection #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
I would avoid this if we can. But if this bug has existed for long, we might not have much of a choice. If we go this route, I would add a deprecation warning so that we can remove it sometime in the future. |
Contributor
Author
|
It was changed in #491, merged in December 2017. At the same time, though, fixing this is really easy. Maybe we could detect a /src/theme directory and warn? |
azerupi
approved these changes
May 16, 2018
Contributor
|
I agree with you. The warning should suffice :) |
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
Fix default theme dir selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #695
Another option would be to accept both
/themeand/src/theme, since some may have begun relying on the undocumented behavior.