Upgrade to shlex 1 #1471
Merged
Upgrade to shlex 1 #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is also being used here so should be safe. Thanks a lot |
notriddle
pushed a commit
to notriddle/mdBook
that referenced
this pull request
Dec 23, 2021
rubenmoor
pushed a commit
to rubenmoor/mdBook
that referenced
this pull request
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the shlex dependency from version 0.1 to 1. The breaking change in shlex 1 is a fix for a correctness bug. I haven't looked closely at how shlex is used in mdbook so it should probably be made sure that this doesn't break anything that relied on the incorrect behavior.