Skip to content

Fix a wrong version 0.4.4 in Cargo.toml (Should be 0.4.5) #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Dylan-DPC-zz merged 1 commit into from
Jan 7, 2021
Merged

Fix a wrong version 0.4.4 in Cargo.toml (Should be 0.4.5) #1435

Dylan-DPC-zz merged 1 commit into from
Jan 7, 2021

Conversation

@tatsuya6502
Copy link
Contributor

@tatsuya6502 tatsuya6502 commented Jan 7, 2021

This pull request updates the version in Cargo.toml from 0.4.4 to 0.4.5, so that it matches to the one published to crate.io.

Problem Description

v0.4.5 has been published to crates.io, but Cargo.toml in this repository left unchanged as 0.4.4.

$ git clone [email protected]:rust-lang-ja/mdBook.git
$ cd mdBook/

$ git show  
commit 09e7bb76dc1d1f565a0678a9f8d3caa0164631cb (HEAD -> master, origin/master, origin/HEAD)
Author: ...
Date:   Tue Jan 5 10:31:16 2021 -0800

$ cargo run -- --version
...
mdbook v0.4.4    # <== Wrong version. Should be v0.4.5

$ rg 'version =' Cargo.toml | head -1
version = "0.4.4"

The one published to crate.io has the correct version.

$ curl -L https://static.crates.io/crates/mdbook/mdbook-0.4.5.crate -o mdbook-0.4.5.tar.gz
$ tar xf mdbook-0.4.5.tar.gz
$ cd mdbook-0.4.5/
$ rg 'version =' Cargo.toml | head -1
version = "0.4.5"

@Dylan-DPC-zz Dylan-DPC-zz merged commit 218e200 into rust-lang:master Jan 7, 2021
@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented Jan 7, 2021

Thanks

@tatsuya6502 tatsuya6502 deleted the fix-version-mismatch branch January 7, 2021 14:00
notriddle pushed a commit to notriddle/mdBook that referenced this pull request Dec 23, 2021
@tatsuya6502 @notriddle
Fix a wrong version 0.4.4 in Cargo.toml (Should be 0.4.5) (rust-lang#…
317c75d 
…1435)
rubenmoor pushed a commit to rubenmoor/mdBook that referenced this pull request Aug 5, 2022
@tatsuya6502 @rubenmoor
Fix a wrong version 0.4.4 in Cargo.toml (Should be 0.4.5) (rust-lang#…
5862d6b 
…1435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tatsuya6502 @Dylan-DPC-zz