-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 0.4.21 release #617
Conversation
Should this be a minor change? I think we need to add two lines to the CI workflow as described here: - name: Check semver
uses: obi1kenobi/cargo-semver-checks-action@v2 |
I just added #618 - it might need to go in first to make sure we are not accidentally breaking semver contract |
P.S. yes, it is clearly failing, possibly due to the current Cargo.toml having the same version as the published one. It seems patch version bump is not enough though. My practice with that checker is that the version in the github main branch should be changed as soon as the breaking change is introduced. So either keep it as |
What breaking changes do we have?
Let's discuss this in the other pr. |
@Thomasdezeeuw I see a bunch of the breaking changes in https://github.com/rust-lang/log/actions/runs/8072374937/job/22053982534?pr=618 -- do you think they are not correct? |
Looking at that output. The as_map and as_list related stuff was removed on purpose. So it LGTM, all the changes were part of the unstable API. |
Shipping this now 👍 I'll keep an eye on it over the next little while because releases with macro changes always come with risk. |
@Thomasdezeeuw I've invited you to the organization I created where |
cc @Thomasdezeeuw @JohnTitor This release stabilizes our structured logging API.
Closes #616
What's Changed
STATIC_MAX_LEVEL
by @ptosi in Clarify documentation and simplify initialization ofSTATIC_MAX_LEVEL
#594ok_or
in favor ofOption::ok_or
by @AngelicosPhosphoros in Removeok_or
in favor ofOption::ok_or
#607Acquire
ordering for initialization check by @AngelicosPhosphoros in UseAcquire
ordering for initialization check #610