Replace value internals with external crate #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodrAus
force-pushed
the
feat/value-bag
branch
4 times, most recently
from
fcc9005
to
e2fcf91
Compare
KodrAus
force-pushed
the
feat/value-bag
branch
from
e2fcf91
to
84b78e2
Compare
KodrAus
force-pushed
the
feat/value-bag
branch
from
5dfe30b
to
71d6ed3
Compare
This was referenced Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also closes #408
This removes all the complexity we've accumulated in the
kv::valueAPI by replacing it with an external crate calledvalue-bag. It's exactly the API we had here, but with support forstd::error::Errorand deals with the reverted const type ids properly.